Messages in this thread | | | Date | Wed, 3 Mar 2004 11:52:47 +0100 | From | Pavel Machek <> | Subject | Re: [Kgdb-bugreport] [KGDB][RFC] Send a fuller T packet |
| |
Hi!
> > I would really like to keep this stuff out of kgdb.h since it may be > > included by the user to pick up the BREAKPOINT() (which, by the way we > > should standardize as I note that here it has () while not on the current > > x86). > > It's BREAKPOINT() everywhere: > $ grep BREAKPOINT include/asm-*/kgdb.h > include/asm-i386/kgdb.h:#define BREAKPOINT() asm(" int $3"); > include/asm-ppc/kgdb.h:#define BREAKPOINT() asm(".long 0x7d821008") /* twge r2, r2 */ > include/asm-x86_64/kgdb.h:#define BREAKPOINT() asm(" int $3");
Notice how it ends with ';' on everything but ppc. Perhaps it needs do { } while (0) wrapping? Pavel -- When do you have a heart between your knees? [Johanka's followup: and *two* hearts?] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |