Messages in this thread | | | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: Kill IDE debug messages during suspend | Date | Mon, 29 Mar 2004 00:55:25 +0200 |
| |
On Monday 29 of March 2004 00:25, Pavel Machek wrote: > Hi! > > > What about these stale #ifdefs? > > > > drivers/ide/ide-io.c:126:#ifdef DEBUG_PM > > drivers/ide/ide-io.c:220:#ifdef DEBUG_PM > > drivers/ide/ide-io.c:638:#ifdef DEBUG_PM > > drivers/ide/ide-io.c:662:#ifdef DEBUG_PM > > I wanted to leave debugging possible... > > > This patch sweeps up both DEBUG_PM and DEBUG #ifdefs in favour of > > pr_debug()
Well, I doubt anybody wants to debug taskfile IOs and PM at the same time. [ pm_debug() ? ]
BTW adding -DDEBUG to EXTRA_CFLAGS in Makefile is cleaner than defining/undefining it inside .c or .h.
> ...but your patch looks better. > Pavel > > > ide-io.c | 74 > > ++++++++++++++++++++++++++-------------------------------------
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |