Messages in this thread | | | Date | Sun, 28 Mar 2004 12:16:01 -0800 | From | "David S. Miller" <> | Subject | Re: [PATCH-2.4.26] ip6tables cleanup |
| |
On 28 Mar 2004 21:27:09 +0200 Peter Osterlund <petero2@telia.com> wrote:
> Willy TARREAU <willy@w.ods.org> writes: > > > 2.4.26-rc1 returned this warning compiling ip6_tables : > > > > ip6_tables.c: In function `tcp_match': > > ip6_tables.c:1596: warning: implicit declaration of function `ipv6_skip_exthdr' > > > > I had to add a cast because ipv6_skip_exthdr() expects a 'struct sk_buff*' while > > its caller uses a 'const struct sk_buff*'. Here is a cleanup patch. > > I think it would be better to change the ipv6_skip_exthdr() function > to take a const struct sk_buff* instead. Unnecessary casts are evil.
Yes, and I believe this is how I fixed this warning in the 2.6.x tree. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |