lkml.org 
[lkml]   [2004]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC][PATCH 1/3] radix priority search tree - objrmap complexity fix
    On Thu, Mar 25, 2004 at 11:06:50PM -0500, Rajesh Venkatasubramanian wrote:
    >
    > Hi Andrea,
    >
    > I am yet to look at the new -aa you released. A small change is
    > required below. Currently, I cannot generate a patch. Sorry. Please
    > fix it by hand. Thanks.
    >
    > >
    > > - list_for_each_entry(vma, list, shared) {
    > > + vma = __vma_prio_tree_first(root, &iter, h_pgoff, h_pgoff);
    >
    > This should be:
    > vma = __vma_prio_tree_first(root, &iter, h_pgoff, ULONG_MAX);
    >
    > > + while (vma) {
    > > unsigned long h_vm_pgoff;
    > [snip]
    > > + vma = __vma_prio_tree_next(vma, root, &iter, h_pgoff, h_pgoff);
    > > }
    >
    > and here it should be:
    > vma = __vma_prio_tree_next(vma, root, &iter,
    > h_pgoff, ULONG_MAX);

    I was missing all vmas with vm_start starting after h_pgoff. Thanks.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:01    [W:0.024 / U:18.132 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site