lkml.org 
[lkml]   [2004]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: 2.6.5-rc1-mm1
piotr@larroy.com (Pedro Larroy) wrote:
>
> On Mon, Mar 22, 2004 at 07:33:27AM -0800, Andrew Morton wrote:
> > piotr@larroy.com (Pedro Larroy) wrote:
> > >
> > > Where would kernel leaked ram be accounted?
> >
> > /proc/meminfo, /proc/vmstat and /proc/slabinfo. Also sysrq-M.

A memory leak was introduced in the ext3 changes.



25-akpm/fs/jbd/commit.c | 8 ++++++++
1 files changed, 8 insertions(+)

diff -puN fs/jbd/commit.c~jbd-move-locked-buffers-leak-fixes fs/jbd/commit.c
--- 25/fs/jbd/commit.c~jbd-move-locked-buffers-leak-fixes 2004-03-22 19:34:37.492865816 -0800
+++ 25-akpm/fs/jbd/commit.c 2004-03-22 19:34:41.987182576 -0800
@@ -296,6 +296,13 @@ write_out_data:
}
}

+ if (bufs) {
+ spin_unlock(&journal->j_list_lock);
+ ll_rw_block(WRITE, bufs, wbuf);
+ journal_brelse_array(wbuf, bufs);
+ spin_lock(&journal->j_list_lock);
+ }
+
/*
* Wait for all previously submitted IO to complete.
*/
@@ -322,6 +329,7 @@ write_out_data:
jh->b_transaction = NULL;
jbd_unlock_bh_state(bh);
journal_remove_journal_head(bh);
+ put_bh(bh);
} else {
jbd_unlock_bh_state(bh);
}
_

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:01    [W:0.265 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site