lkml.org 
[lkml]   [2004]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] anobjrmap 1/6 objrmap
>> I tried the aa3 equiv of the above, just on top of virgin 2.6.5-rc1, but 
>> it doesn't work cleanly. Your whole aa3 tree runs nicely, but I'd prefer
>> to have the broken out patch before publishing comparisons, as otherwise
>> it's a bit unfair ;-) I'm not sure if the results come from your anon_vma
>> approach, or other patches in your tree ...
>>
>> I'm presuming you shifted the cost of find_get_page into find_trylock_page
>> and pgd_ctor into pgd_alloc from the profiles below ...
>
> I cannot see how can find_trylock_page be affected by my anon_vma
> changes. The only difference I can see is taht Andrew's -mm writeback
> code is adding the _irq to the spinlocks there and I don't see other
> obvious changes in that function. I included all -mm writeback changes
> primarly to avoid me to maintain two slightly different versions of
> anon_vma and secondly to nuke the page->list. Other trees I'm dealing
> with daily have those applied already. At the very least that
> additional cost that you measured cannot be associated in any way with
> the allocation and maintainace of the anon_vma, since that
> find_trylock_page cost is a per-page pagecache thing absolutely
> unrelated to the anon_vmas costs.
>
> It's probably best that I port my version of objrmap (basically the same
> as yours but with the shm swapout fixes) + anon_vma to your tree, it's
> not a big effort to do the porting once, I applied Andrew's patches
> primarly to avoid porting back and forth all the time.
>
> Just tell me which is exactly the codebase I should port against and
> I'll send you a patch shortly.

Just against 2.6.5-rc1 virgin is easiest - that's what I was doing the
rest of it against ...

Thanks,

M.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:01    [W:0.149 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site