Messages in this thread Patch in this message | | | Date | Mon, 22 Mar 2004 05:34:54 +0100 | From | Andrea Arcangeli <> | Subject | Re: [PATCH] Drop O_LARGEFILE from F_GETFL for POSIX compliance |
| |
On Mon, Mar 22, 2004 at 05:13:18AM +0100, Andi Kleen wrote: > > On 64bit architectures open() sets O_LARGEFILE implicitely. This causes the LSB > testsuite to fail, which checks that F_GETFL only returns the flags set by > a previous open. > > According to the POSIX standards gurus the Linux behaviour is not compliant. > > This patch fixes this by just not reporting O_LARGEFILE in F_GETFL. > > This has been in several shipping SuSE releases and the x86-64.org CVS > treee for a long time, so is unlikely to break anything. > > -Andi > > diff -burpN -X ../KDIFX linux-2.4.26-pre5/fs/fcntl.c linux-merge/fs/fcntl.c > --- linux-2.4.26-pre5/fs/fcntl.c 2004-01-13 10:29:17.000000000 +0100 > +++ linux-merge/fs/fcntl.c 2003-10-23 15:40:52.000000000 +0200 > @@ -271,7 +271,7 @@ static long do_fcntl(unsigned int fd, un > set_close_on_exec(fd, arg&1); > break; > case F_GETFL: > - err = filp->f_flags; > + err = filp->f_flags & ~O_LARGEFILE; > break; > case F_SETFL: > lock_kernel(); > -
in my 2.4 tree I have this one instead (written in oct 2002):
--- x/fs/fcntl.c.~1~ Wed Oct 16 17:26:27 2002 +++ x/fs/fcntl.c Wed Oct 16 17:27:43 2002 @@ -277,7 +277,11 @@ static long do_fcntl(unsigned int fd, un set_close_on_exec(fd, arg&1); break; case F_GETFL: +#if BITS_PER_LONG != 32 + err = filp->f_flags & ~O_LARGEFILE; +#else err = filp->f_flags; +#endif break; case F_SETFL: err = setfl(fd, filp, arg);
32bit archs needs to get O_LARGEFILE in return from getfl (if they set it [it's not set implicitly in 32bit archs] they will be able to handle it transparently in glibc too, and I believe they really want it). 64bit archs not, hence the fix. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |