lkml.org 
[lkml]   [2004]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Small bug in bio_clone?
On Fri, Mar 19 2004, Russell Cattelan wrote:
> Shouldn't __bio_clone be checking the state flags
> of the src bio?
>
> --- /usr/tmp/TmpDir.29150-0/fs/bio.c_1.3 2004-03-19
> 16:07:12.000000000 -0600
> +++ fs/bio.c 2004-03-19 16:06:24.348491070 -0600
> @@ -225,7 +225,7 @@
> */
> bio->bi_vcnt = bio_src->bi_vcnt;
> bio->bi_idx = bio_src->bi_idx;
> - if (bio_flagged(bio, BIO_SEG_VALID)) {
> + if (bio_flagged(bio_src, BIO_SEG_VALID)) {
> bio->bi_phys_segments = bio_src->bi_phys_segments;
> bio->bi_hw_segments = bio_src->bi_hw_segments;
> bio->bi_flags |= (1 << BIO_SEG_VALID);

Yes, in theory. What is done now is for sure a mistake, however I'm
thinking it's probably safer to just delete the check and setting of
segments, and do it on-demand the next time (if ever) someone calls
bio_*_segments(bio). Hmm, should be done every time someone assigns
->bi_bdev(), maybe it would be a good idea to add something like that.

static inline void bio_set_bdev(struct bio *bio, struct block_device *bdev)
{
bio->bi_bdev = bdev;
bio->bi_flags &= ~(1 << BIO_SEG_VALID);
}

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:01    [W:0.024 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site