Messages in this thread | | | Date | Tue, 02 Mar 2004 18:08:24 -0500 | From | Jeff Garzik <> | Subject | Re: [PATCH] IDE cleanups for 2.6.4-rc1 (2/3) |
| |
Bartlomiej Zolnierkiewicz wrote: > [IDE] remove ide_cmd_type_parser() logic > > Set ide_task_t fields (command_type, handler and prehandler) directly. > Remove unused ide_task_t->posthandler and all ide_cmd_type_parser() logic. > > ide_cmd_type_parser() was meant to be used for ioctls but > ended up checking validity of kernel generated requests (doh!). > > Rationale for removal: > - it can't be used for existing ioctls (changes the way they work) > - kernel shouldn't check validity of (root only) user-space requests > (it can and should be done in user-space) > - it wastes CPU cycles on going through parsers > - it makes code harder to understand/follow > (now info about request is localized)
Without the annoyingly-large 'switch', how do you figure out whether a command is non-data, pio-read, pio-write, dma-read, or dma-write?
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |