Messages in this thread | | | Date | Fri, 19 Mar 2004 17:36:50 +0100 | From | Vojtech Pavlik <> | Subject | Re: [3C509] Fix sysfs leak. |
| |
On Tue, Mar 16, 2004 at 10:58:08AM -0500, Richard B. Johnson wrote: > On Tue, 16 Mar 2004, Dave Jones wrote: > > > On Tue, Mar 16, 2004 at 03:09:49PM +0100, Marc Zyngier wrote: > > > >>>>> "Dave" == Dave Jones <davej@redhat.com> writes: > > > > > > Dave> Then the probing routine is bogus, it returns 0 when it fails too. > > > > > > Uh ? el3_eisa_probe looks like it properly returns an error... > > > > > > Or maybe you call a failure not finding a proper device on the bus ? > > > > The damned bus doesn't even exist. If this is a case that couldn't be > > detected, I'd not be complaining, but this is just nonsense having > > a driver claim that its found an EISA device, when there aren't even > > any EISA slots on the board. > > There is no way that any software knows about an EISA bus. It > only knows that there is some device at some port. Since a 3c503 > was built to go into an 8-bit EISA slot, if one is found it > is assumed to be in such a slot on the EISA bus! > > So, if the device doesn't exist there is a problem with the > detection method for the device, not a detection method for > a bus because the bus can't be detected at all.
3c503 in EISA? 8-bit EISA? I think you mean ISA ...
EISA has slot information available, as far as I know, and device identifiers and ... and is a 32-bit bus.
-- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |