Messages in this thread | | | Date | Tue, 16 Mar 2004 01:51:41 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] Driver Core update for 2.6.4 |
| |
Christoph Hellwig <hch@infradead.org> wrote: > > On Mon, Mar 15, 2004 at 03:59:09PM -0800, Greg KH wrote: > > ChangeSet 1.1608.84.16, 2004/03/15 14:39:18-08:00, greg@kroah.com > > > > kref: add kref structure to kernel tree. > > > > Based on the kobject structure, but much smaller and simpler to use. > > Didn't everyone who reviewed this say it's useless bloat.
No.
bix:/usr/src/25> wc -l include/linux/kref.h lib/kref.c 32 include/linux/kref.h 60 lib/kref.c 92 total
bix:/usr/src/25> size lib/kref.o text data bss dec hex filename 368 0 0 368 170 lib/kref.o
> Andi even got > so far as calling it obsfucation, given that hides simple things behind > an overly complex and wastefull abstraction.
eh? If there is any argument against this code it is that it is so simple that the thing which it abstracts is not worth abstracting. But given that it is so unwasteful, this seems unimportant.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |