lkml.org 
[lkml]   [2004]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 9/44] Support for scroll wheel on Office keyboards
From
Date
On Tue, 2004-03-16 at 09:19, Vojtech Pavlik wrote:
> You can pull this changeset from:
> bk://kernel.bkbits.net/vojtech/input
>
> ===================================================================
>
> ChangeSet@1.1474.188.9, 2004-01-26 13:56:47+01:00, vojtech@suse.cz
> input: Add support for scroll wheel on MS Office and similar keyboards.
>
>
> atkbd.c | 65 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------
> 1 files changed, 58 insertions(+), 7 deletions(-)
>
> ===================================================================
>
> diff -Nru a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
> --- a/drivers/input/keyboard/atkbd.c Tue Mar 16 13:19:47 2004
> +++ b/drivers/input/keyboard/atkbd.c Tue Mar 16 13:19:47 2004
> @@ -33,18 +33,18 @@
> MODULE_PARM(atkbd_set, "1i");
> MODULE_PARM(atkbd_reset, "1i");
> MODULE_PARM(atkbd_softrepeat, "1i");
> +MODULE_PARM(atkbd_scroll, "1i");
> MODULE_LICENSE("GPL");
>
> static int atkbd_set = 2;
> module_param_named(set, atkbd_set, int, 0);
> MODULE_PARM_DESC(set, "Select keyboard code set (2 = default, 3, 4)");
> +
> #if defined(__i386__) || defined(__x86_64__) || defined(__hppa__)
> static int atkbd_reset;
> #else
> static int atkbd_reset = 1;
> #endif
> -static int atkbd_softrepeat;
> -
> module_param_named(reset, atkbd_reset, bool, 0);
> MODULE_PARM_DESC(reset, "Reset keyboard during initialization");
>
> @@ -52,6 +52,10 @@
> module_param_named(softrepeat, atkbd_softrepeat, bool, 0);
> MODULE_PARM_DESC(softrepeat, "Use software keyboard repeat");
>
> +static int atkbd_scroll;
> +module_parm_named(scroll, atkbd_scroll, bool, 0);
> +MODULE_PARM_DESC_(scroll, "Enable scroll-wheel on office keyboards");
^^forgive me if i am wrong, but should that not be
module_param_named, like the rest? (eg the second 'a' is missing).
also, why MODULE_PARM_DESC_ instead of MODULE_PARM_DESC? (extra
underscore)

--aubin

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:01    [from the cache]
©2003-2011 Jasper Spaans