Messages in this thread | | | Date | Sat, 13 Mar 2004 21:47:00 -0800 | From | Andrew Morton <> | Subject | Re: possible kernel bug in signal transit. |
| |
Alex Lyashkov <shadow@psoft.net> wrote: > > > int __kill_pg_info(int sig, struct siginfo *info, pid_t pgrp) > > { > > struct task_struct *p; > > struct list_head *l; > > struct pid *pid; > > int retval; > > int found; > > > > if (pgrp <= 0) > > return -EINVAL; > > > > found = 0; > > retval = 0; > > for_each_task_pid(pgrp, PIDTYPE_PGID, p, l, pid) { > > int err; > > > > found = 1; > > err = group_send_sig_info(sig, info, p); > > if (!retval) > > retval = err; > > } > > return found ? retval : -ESRCH; > > } > not. it error. At this code you save first non zero value err but other > been ignored.
Well we can only return one error code. Or are you suggesting that we should terminate the loop early on error? If so, why? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |