lkml.org 
[lkml]   [2004]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] s390 (8/10): zfcp fixes.
On Fri, Mar 12, 2004 at 08:38:16PM +0100, Martin Schwidefsky wrote:
> zfcp host adapter fixes:
> - Reuse freed scsi_ids and scsi_luns for mappings.
> - Order list of ports/units by assigned scsi_id/scsi_lun.
> - Don't update max_id/max_lun in scsi_host anymore.
> - Get rid of all magics.
> - Add owner field to ccw_driver structure.
> - Replace release function for device structures by kfree. Move struct
> device to the start of struct zfcp_port/zfcp_unit to make it work.

Ick, ick, ick!

Why? Please do not do this, as it is not needed, and completly
unnecessary. The fact that you have to create a cast like:

> + unit->sysfs_device.release = (void (*)(struct device *))kfree;

Should set off all kinds of "this is a something we should not be doing"
warning flags.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:01    [W:1.124 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site