Messages in this thread | | | Date | Thu, 11 Mar 2004 18:42:30 +0100 | From | Stefan Smietanowski <> | Subject | Re: (0 == foo), rather than (foo == 0) |
| |
Hi Andreas.
>>>>The warning should be there whether there are parenthesis or not, >>>>and it should state that you should have an explicit inequality >>>>expression. So if you have >>>> if (a = b) ... >>>>and you really _mean_ that, then the way to write it sanely is to >>>>just write it as >>>> if ((a = b) != 0) >>>> ... >>>>which makes it much clearer what you're actually doing. >>> >>>Or actually change it to >>> >>>a = b; >>>if (a) >> >>That doesn't work with while(). > > > But this works: while (a = b, a != 0). > (not that it is any better readable :-) ).
My eyes! *Starts clawing them out*
// Stefan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |