Messages in this thread | | | Date | Wed, 10 Mar 2004 16:29:23 +0000 (GMT) | From | Thomas Horsten <> | Subject | Re: [PATCH] 2.4.x Linux Medley RAID Version 7 |
| |
On Wed, 10 Mar 2004, Bartlomiej Zolnierkiewicz wrote:
> Ideally I would like you to split your driver on a set of patches against > sil_raid.c but it will be sufficient if you clean this patch a bit. > [ Please read Documentation/CodingStyle. ] > [...] > Patch for inclusion should have this cleaned up.
I'll clean it and resubmit.
> + /* If this drive is not on a PCI controller, it is not Medley RAID. > + * Medley matches the PCI device ID with the metadata to check if it is valid. */ > + pcidev = drvinfo->hwif?drvinfo->hwif->pci_dev:NULL; > + if (!pcidev) > + { > + return NULL; > + } > > IMHO this is redundant/bogus -> I can get drives with Medley RAID off CMD/SiI > controller and plug them into legacy ISA controller and still be happy > (hey, it is a Linux way of doing things). [...] > > + /* A valid Medley RAID has the PCI vendor/device ID of its IDE controller, > + * and the correct checksum. */ > + md = (void *)(bh->b_data); > + > + if (pcidev->vendor == md->vendor_id && pcidev->device == md->product_id) > > The similar thing here - ie. I would like to replug drives to on-board Intel. > When Linux is driving RAID purely in software it shouldn't matter what > controller we are using.
I see your point, but it's the Medley standard and the "official" way they detect the array. If I can't compare with the PCI vendor and device ID, I have no reliable way (other than heuristics) to see if it is a valid Medley superblock.. There are many different variants of Medley out there, and they each use their own vendor/device ID as the superblock magic word.
So I would prefer to keep these.
Thanks, Thomas
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |