Messages in this thread | | | Date | Tue, 10 Feb 2004 01:35:50 +0100 (CET) | From | Roman Zippel <> | Subject | Re: [2.6 PATCH] persist qconf options |
| |
Hi,
On Mon, 9 Feb 2004, Andreas Fester wrote:
> @@ -1145,6 +1162,10 @@ > menuList->updateListAll(); > } > > +bool ConfigMainWindow::getShowAll() { > + return configList->showAll; > +} > + > void ConfigMainWindow::setShowDebug(bool b) > { > if (showDebug == b)
All these access functions are really not neccessary. If we change this I'd like to see this done properly. First all the settings business should be moved into a small helper class, so that there are not x number of new arguments to the ConfigList constructor. The saving of the settings should be connected to aboutToQuit(). Bonus points if you also save the list mode and the position of the splitter. :)
bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |