Messages in this thread Patch in this message | | | Date | Sun, 8 Feb 2004 00:14:24 -0800 | From | Andrew Morton <> | Subject | Re: Oopses on usbnet unload in 2.6.3-rc1 |
| |
Petr Vandrovec <vandrove@vc.cvut.cz> wrote: > > recent thread about buggy sysfs fbdev support reminded me that situation > with modules unloading is not quite correct... Besides floppy & nbd unload > crashes (I already reported floppy/sysfs problem during Christmas),
Could you please rereport the floppy and nbd problems?
> there > is a doublefree in usbnet's unload. I have no idea what's correct fix, but > given fbdev's problems probably just removing kfree(dev->net).
usbnet has relevant changes in Jeff's tree (and hence in -mm).
diff -Nru a/drivers/usb/net/usbnet.c b/drivers/usb/net/usbnet.c --- a/drivers/usb/net/usbnet.c Sat Feb 7 17:16:08 2004 +++ b/drivers/usb/net/usbnet.c Sat Feb 7 17:16:08 2004 @@ -2933,7 +2933,7 @@ if (dev->driver_info->unbind) dev->driver_info->unbind (dev, intf); - kfree(dev->net); + free_netdev(dev->net); kfree (dev); usb_put_dev (xdev); } @@ -3061,7 +3061,7 @@ if (info->unbind) info->unbind (dev, udev); out2: - kfree(net); + free_netdev(net); out1: kfree(dev); out: - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |