Messages in this thread | | | Subject | RE: [Infiniband-general] Getting an Infiniband access layer in theLinux kernel | Date | Fri, 6 Feb 2004 08:42:14 -0800 | From | "Hefty, Sean" <> |
| |
On Thu, Feb 5, 2004 at 05:11:00PM -0800, Troy Benjegerdes wrote: >On Thu, Feb 05, 2004 at 02:26:46PM -0800, Hefty, Sean wrote: >> Personally, I'm amazed that professional developers have to discuss or >> defend modular, portable code. > >You're new to linux-kernel, aren't you? ;)
I was not trying to be condescending. My point was that I think that everyone on this list knows the purpose and benefits behind an abstraction layer. It's not something that needed to be discussed any further.
I also understand that code in the Linux 2.6 kernel does not need certain abstractions. And I agree that because we are targeting the 2.6 kernel specifically, the existing code, some of which was developed 3-5 years ago, should be updated based on what the 2.6 kernel provides.
We want to continue to discuss specific details about what's needed to add the code into the kernel. Here's a list of modifications that I think are needed so far:
* Update the code to make direct calls for atomic operations. * Verify the use of spinlock calls. * Reformat the code for tab spacing and curly brace usage. * Elimination of typedefs.
And, yes, knowing some of these issues up front will save the trouble of submitting code that will be immediately rejected. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |