Messages in this thread Patch in this message | | | Subject | Re: [Bugme-new] [Bug 2019] New: Bug from the mm subsystem involving X (fwd) | From | Keith Mannthey <> | Date | 04 Feb 2004 17:56:49 -0800 |
| |
On Wed, 2004-02-04 at 17:29, Linus Torvalds wrote: > > So it does need to be fixed, and if it ends up being a noticeable > perofmance problem, then we can look at the hot-paths one by one and see > if we can avoid using it. We probably can, most of the time. >
Martin sent me a patch that fixed the X panics (NUMA and DISCONTIG enabled). (Thanks Martin!) I don't have the same X panics and issues I had before. I don't know if this will work for the generic case. It compiles with a simple memory situation just fine but I didn't boot it.
diff -purN -X /home/mbligh/.diff.exclude virgin/include/asm-i386/mmzone.h pfn_valid/include/asm-i386/mmzone.h --- virgin/include/asm-i386/mmzone.h 2003-10-01 11:48:22.000000000 -0700 +++ pfn_valid/include/asm-i386/mmzone.h 2004-02-04 16:39:12.000000000 -0800 @@ -84,14 +84,8 @@ extern struct pglist_data *node_data[]; + __zone->zone_start_pfn; \ }) #define pmd_page(pmd) (pfn_to_page(pmd_val(pmd) >> PAGE_SHIFT)) -/* - * pfn_valid should be made as fast as possible, and the current definition - * is valid for machines that are NUMA, but still contiguous, which is what - * is currently supported. A more generalised, but slower definition would - * be something like this - mbligh: - * ( pfn_to_pgdat(pfn) && ((pfn) < node_end_pfn(pfn_to_nid(pfn))) ) - */ -#define pfn_valid(pfn) ((pfn) < num_physpages) + +#define pfn_valid(pfn) ( pfn_to_pgdat(pfn) && ((pfn) < node_end_pfn(pfn_to_nid(pfn))) ) /* * generic node memory support, the following assumptions apply:
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |