Messages in this thread | | | Date | Tue, 3 Feb 2004 13:18:15 -0800 | From | "Randy.Dunlap" <> | Subject | Re: [PATCH] add syscalls.h |
| |
On Tue, 3 Feb 2004 14:29:16 -0600 Matt Mackall <mpm@selenic.com> wrote:
| On Sun, Feb 01, 2004 at 10:43:44PM -0800, Andrew Morton wrote: | > +extern asmlinkage long sys_unlink(const char __user *pathname); | > +extern asmlinkage long sys_chmod(const char __user *filename, mode_t mode); | > +extern asmlinkage long sys_fchmod(unsigned int fd, mode_t mode); | > | > Maybe lose the `extern' too. It's just a waste of space. I normally put | > it in for consistency if the surrounding code is done that way, but for a | > new header file, why bother? | | I'd really like to see the extern go, if only to discourage that | particular bit of cargo cult programming. There are actually people | who think it serves a purpose..
They are already gone in the v2 version of the patch.
-- ~Randy kernel-janitors project: http://janitor.kernelnewbies.org/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |