Messages in this thread Patch in this message | | | Subject | [PATCH] PCI fixes for 2.6.4-rc1 | Date | Fri, 27 Feb 2004 16:09:42 -0800 | From | Greg KH <> |
| |
ChangeSet 1.1613, 2004/02/24 11:07:29-08:00, rmk-pci@arm.linux.org.uk
[PATCH] PCI: Report meaningful error for failed resource allocation
pci_assign_resource reports odd messages when resource allocation fails. This is because res->end and res->start are modified by allocate_resource. For example:
PCI: Failed to allocate resource 1(0-ffffffff) for 0000:00:01.0
The following patch reports whether it's an IO or memory resource, and includes the correct size. For consistency, we report it in a similar way to the failure message in pci_request_region(), even though res->start is unlikely to be useful.
drivers/pci/setup-res.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)
diff -Nru a/drivers/pci/setup-res.c b/drivers/pci/setup-res.c --- a/drivers/pci/setup-res.c Fri Feb 27 15:57:35 2004 +++ b/drivers/pci/setup-res.c Fri Feb 27 15:57:35 2004 @@ -143,8 +143,9 @@ } if (ret) { - printk(KERN_ERR "PCI: Failed to allocate resource %d(%lx-%lx) for %s\n", - resno, res->start, res->end, pci_name(dev)); + printk(KERN_ERR "PCI: Failed to allocate %s resource #%d:%lx@%lx for %s\n", + res->flags & IORESOURCE_IO ? "I/O" : "mem", + resno, size, res->start, pci_name(dev)); } else if (resno < PCI_BRIDGE_RESOURCES) { pci_update_resource(dev, res, resno); } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |