lkml.org 
[lkml]   [2004]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][1/2] dm-crypt cleanups
Christophe Saout wrote:
> +#include <asm/atomic.h>
> #include <asm/scatterlist.h>
>
> #include "dm.h"
>
> +#define PFX "crypt: "
> +
> /*
> * per bio private data
> */
> @@ -416,7 +419,7 @@
> int key_size;
>
> if (argc != 5) {
> - ti->error = "dm-crypt: Not enough arguments";
> + ti->error = PFX "Not enough arguments";
> return -EINVAL;
> }
>


Looks good, except that PFX should be defined to "dm-crypt: " to reduce
confusion... "crypt" is rather generic, and could be construed to be
unrelated to your module.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:01    [W:0.053 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site