Messages in this thread | | | Date | Thu, 26 Feb 2004 12:21:24 -0500 | From | Jeff Garzik <> | Subject | Re: [PATCH][1/2] dm-crypt cleanups |
| |
Christophe Saout wrote: > +#include <asm/atomic.h> > #include <asm/scatterlist.h> > > #include "dm.h" > > +#define PFX "crypt: " > + > /* > * per bio private data > */ > @@ -416,7 +419,7 @@ > int key_size; > > if (argc != 5) { > - ti->error = "dm-crypt: Not enough arguments"; > + ti->error = PFX "Not enough arguments"; > return -EINVAL; > } >
Looks good, except that PFX should be defined to "dm-crypt: " to reduce confusion... "crypt" is rather generic, and could be construed to be unrelated to your module.
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |