Messages in this thread Patch in this message | | | Date | Wed, 25 Feb 2004 21:46:22 +1100 | Subject | Re: Bug#234631: kernel-source-2.6.3: kernel fails to compile : radeon_setup_i2c_bus etc. | From | Herbert Xu <> |
| |
tags 234631 pending quit
On Wed, Feb 25, 2004 at 09:04:58PM +1100, herbert wrote: > On Tue, Feb 24, 2004 at 11:46:38PM +0100, Olivier Berger wrote: > > Package: kernel-source-2.6.3 > > Version: 2.6.3-2 > > Severity: normal > > > > I can provide the .config corresponding to this kernel if useful. > > Please do. Please also let me know how you arrived at the config > file, i.e., whether you used oldconfig/menuconfig/gconfig.
Never mind, I've found the problem. RADEON is selecting I2C_ALGOBIT but as kconfig currently does not propagate selects up the dependency chain (that is according to Roman), this can leave I2C as m while I2C_ALGOBIT is y.
This patch fixes it by explicitly selecting I2C. -- Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ ) Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt Index: kernel-2.5/drivers/video/Kconfig =================================================================== RCS file: /home/gondolin/herbert/src/CVS/debian/kernel-source-2.5/drivers/video/Kconfig,v retrieving revision 1.11 diff -u -r1.11 Kconfig --- kernel-2.5/drivers/video/Kconfig 19 Feb 2004 09:55:58 -0000 1.11 +++ kernel-2.5/drivers/video/Kconfig 25 Feb 2004 10:46:06 -0000 @@ -463,6 +463,7 @@ tristate "Matrox acceleration" depends on FB && PCI select I2C_ALGOBIT if FB_MATROX_I2C + select I2C if FB_MATROX_I2C ---help--- Say Y here if you have a Matrox Millennium, Matrox Millennium II, Matrox Mystique, Matrox Mystique 220, Matrox Productiva G100, Matrox @@ -628,6 +629,7 @@ tristate "ATI Radeon display support" depends on FB && PCI select I2C_ALGOBIT if FB_RADEON_I2C + select I2C if FB_RADEON_I2C help Choose this option if you want to use an ATI Radeon graphics card as a framebuffer device. There are both PCI and AGP versions. You | |