Messages in this thread | | | Date | Tue, 24 Feb 2004 17:06:26 +0000 | From | Christoph Hellwig <> | Subject | Re: [PATCH] 2.6.2, Partition support for SCSI CDROM... |
| |
On Tue, Feb 24, 2004 at 11:51:20AM -0500, Steven J. Hill wrote: > Here is the second try at the patch. > > -Steve
+static int partitions = 16;
This is changes what sr1 is mapped to without specicying any option. The default _must_ be 0 partitions or existing setups will break.
+MODULE_PARM(partitions, "i");
please make this module_param so it works at boot-time aswell.
+MODULE_PARM_DESC(partitions, "number of SCSI CDROM partitions to support");
+ /* Check number of partitions specified. */ + if (partitions < 0) + partitions = 0;
now if you made the variable 'unsigned' you wouldn't have that problem..
While you're at it please also cook up an ide-cd variant, having partitions only supported on scsi cdroms is more than confusing. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |