Messages in this thread | | | Date | Mon, 23 Feb 2004 12:57:30 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] fix shmat |
| |
Manfred Spraul <manfred@colorfullife.com> wrote: > > On Mon, 23 Feb 2004, Linus Torvalds wrote: > > > > Please. Maybe it might even be worth-while renaming it to "do_sys_shmat()" > > to make it clear that it's not a "sys_xxx()" at all. > > > > Below is a patch that renames sys_shmat to do_shmat. Additionally, I've > replaced the cond_syscall with a conditional inline function.
It doesn't update arch/mips/kernel/scall64-64.S and arch/mips/kernel/scall64-n32.S?
I'd be inclined to leave it as sys_shmat(). It is logically a syscall, and the fact that everyone except mips (and ia64) sticks a multiplexer in front of it is a sad historical note.
It's simply a matter of getting the appropriate prototype in scope for all the C callers. For now, I'd be inclined to bung the prototype in kernel.h, because Randy's syscalls.h patches will fix all this for real in a week or two. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |