Messages in this thread | | | Date | Sat, 21 Feb 2004 19:48:57 +0100 | From | Pavel Machek <> | Subject | Re: kernel/microcode.c error from new 64bit code |
| |
Hi!
> > On Sat, 21 Feb 2004, Pavel Machek wrote: > > > > > > I'm just afraid that someone will mail you a patch replacing that with > > > >> 32 and you'll overlook it. > > > > Well, the good news is that ">> 32" should cause gcc to complain with a > > big warning (exactly because it's undefined brhaviour on a 32-bit > > architecture), so I don't think it's easy to overlook. > > What is wrong with the original? > > - wrmsr(MSR_IA32_UCODE_WRITE, (unsigned int)(uci->mc->bits), 0); > > I don't see how anything else could be correct. > > Either we have high bits we need to worry about in 32bit mode, in which > case the 32bit variant is wrong. Or we don't have high bits to worry > about in which case attempting to set them is wrong.
I believe that driver is now shared between i386 and x86-64.
Pavel -- When do you have a heart between your knees? [Johanka's followup: and *two* hearts?] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |