Messages in this thread | | | Date | Fri, 20 Feb 2004 20:58:29 +0200 | From | Mika Penttilä <> | Subject | Re: [PATCH]2.6.3-rc2 MSI Support for IA64 |
| |
ia64 already has a function ia64_alloc_vector(void) in arch/ia64/kernel/irq_ia64, why the doubling?
--Mika
Nguyen, Tom L wrote:
>Friday, Feb. 20, 2004 8:55 AM, Andreas Schwab wrote: > > > >>>@@ -316,6 +310,19 @@ >>> return current_vector; >>> } >>> >>>+int ia64_alloc_vector(void) >>>+{ >>>+ static int next_vector = IA64_FIRST_DEVICE_VECTOR; >>>+ >>>+ if (next_vector > IA64_LAST_DEVICE_VECTOR) >>>+ /* XXX could look for sharable vectors instead of panic'ing... */ >>>+ panic("ia64_alloc_vector: out of interrupt vectors!"); >>>+ >>>+ nr_alloc_vectors++; >>>+ >>>+ return next_vector++; >>>+} >>>+ >>> >>> > > > >>IMHO this should be CONFIG_IA64 only. >> >> > >To avoid some #ifdef statements as possible, "ia64_platform" >defined in the header file "msi.h" is set to TRUE only if >setting CONFIG_IA64 to 'Y'. The setting of ia64_platform >to TRUE will execute function ia64_alloc_vector. > >This API is only used in assign_msi_vector()in msi.c: > > vector = (ia64_platform ? ia64_alloc_vector() : > assign_irq_vector(MSI_AUTO)); > >Thanks, >Long >- >To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >the body of a message to majordomo@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html >Please read the FAQ at http://www.tux.org/lkml/ > > >
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |