Messages in this thread | | | Subject | Re: radeon warning on 64-bit platforms | From | Valdis.Kletnieks@vt ... | Date | Thu, 19 Feb 2004 17:30:44 -0500 |
| |
On Wed, 18 Feb 2004 02:28:31 GMT, Matthew Wilcox said: > On Tue, Feb 17, 2004 at 05:59:12PM -0800, David Mosberger wrote: > > I personally would be more than happy to reformat things to 80 cols, > > but it's a waste of time unless almost all Linux code gets > > reformatted. > > Hm? I don't know where you're getting that from. Let's talk numbers. > > Of the 60525 lines in .c files in arch/i386, 460 are longer than 80 cols. > Of the 67398 lines in .c files in arch/ia64, 1189 are longer than 80 cols. > Of the 496510 lines in .c files in drivers/net, 4044 are longer than 80 cols.
You apparently made the mistake of looking at character count < 80, not lines that extend past column 80.
For 2.6.3-mm1, I see: [/usr/src/linux-2.6.3-mm1/arch/i386]2 find . -name '*.c' | xargs cat | wc -l 64542 [/usr/src/linux-2.6.3-mm1/arch/i386]2 find . -name '*.c' | xargs cat | awk 'length() > 80 { print $0}' | wc -l 477 [/usr/src/linux-2.6.3-mm1/arch/i386]2 find . -name '*.c' | xargs cat |sed 's/\t/ /g'| awk 'length() > 80 { print $0}' | wc -l 1291
(replace \t with whatever your shell needs to enter a literal tab . Yes, this botches on the relatively rare line that has an embedded tab. Deal with it. ;).
In other words, the situation is a lot worse if you count columns, not characters.
(For IA64, it's 67,376 and either 1,185 or 3,222, and for drivers/net I see 493,027 and either 4,004 or 15,606 - ia64 is worse at the 80-col thing either way)
[unhandled content-type:application/pgp-signature] | |