lkml.org 
[lkml]   [2004]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Eureka! (was Re: UTF-8 and case-insensitivity)


    On Thu, 19 Feb 2004 viro@parcelfarce.linux.theplanet.co.uk wrote:
    >
    > On Thu, Feb 19, 2004 at 01:45:32PM -0800, Linus Torvalds wrote:
    > > So we'd see very quickly if these tentative dentries were to escape
    > > outside of __d_lookup().
    >
    > Ahem... You'll see them (at least) in dcache pruning codepaths. And
    > those will dereference inodes...

    Yea, you be right. Many of those paths would not need to care about
    TENTATIVE at all, so using the d_inode thing would make them uglier, I
    agree. Maybe the flag is better after all (and it really should be pretty
    well contained by just checking all __d_lookup callers, so it should be
    hard to get it wrong, but maybe I've forgotten some path).

    We could do it both ways - do the TENTATIVE_INODE thing as a debugging
    thing at first to make sure none of these dentries escape, and then remove
    it (and the unnecessary tests in the pruning paths) once everybody is
    convinced that it is working correctly.

    Linus
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-11-18 23:46    [W:4.061 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site