Messages in this thread | | | Date | Wed, 18 Feb 2004 01:44:22 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] [2.6] UFS2 Read Only Patch |
| |
Niraj Kumar <niraj17@iitbombay.org> wrote: > > lease apply this patch . > They provide the bare minimum read-only support for > ufs2 variant (from FreeBSD 5.x ) of the UFS filesystem . > > The patch for 2.6.3 is here : > http://ufs-linux.sourceforge.net/ufs2/2.6.3/ufs2-read-only-p1.txt > http://ufs-linux.sourceforge.net/ufs2/2.6.3/ufs2-read-only-p2.txt
ooh, I see you have a mkfs.ufs there. Does it support UFS1 as well?
Does current UFS support little-endian machines? If so, has this code been tested on a little-endian host? The code _looks_ OK, but one does need to test...
Has the patched filesystem been regression tested against a UFS1 filesystem?
The patches which you have there are a bit of a disaster coding-style wise.
- Use hard tabs everywhere, not eight-spaces.
- No space before terminating semicolons
-
+ if ( (flags & UFS_TYPE_MASK) == UFS_TYPE_UFS2) + { + uspi->s_u2_size = fs64_to_cpu(sb, usb->fs_u11.fs_u2.fs_size);
should be
if ((flags & UFS_TYPE_MASK) == UFS_TYPE_UFS2) {
etcetera. See Documentation/CodingStyle.
Thanks. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |