lkml.org 
[lkml]   [2004]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC][PATCH} 2.6 and grsecurity
    hi :)

    On Mon, Feb 16, 2004 at 08:34:17PM -0500, Valdis.Kletnieks@vt.edu wrote:
    > spin_lock_bh(&inet_peer_idlock);
    > - id = p->ip_id_count;
    > +#ifdef CONFIG_SECURITY_RANDID
    > + if (security_enable_randid)
    > + id = ip_randomid();
    > + else
    > +#endif
    > + id = p->ip_id_count;

    you could #define security_enable_* to 0 when CONFIG_SECURITY_*
    is disabled. thay way you don't need the ugly #ifdef in the .c file

    on the other hand, why do one need a syscall anyway.
    only to justify the existence of some ugly lockdown mode?

    well, why make it even configurable?
    eigther it increases security, then by all means: enable it
    unconditionally;
    or it doesn't increase security, and why do we need it then?


    --
    CU, / Friedrich-Alexander University Erlangen, Germany
    Martin Waitz // Department of Computer Science 12 _________
    ______________/// - - - - - - - - - - - - - - - - - - - - ///
    dies ist eine manuell generierte mail, sie beinhaltet //
    tippfehler und ist auch ohne grossbuchstaben gueltig. /
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2005-03-22 14:01    [W:0.021 / U:0.540 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site