lkml.org 
[lkml]   [2004]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: 2.6.3rc4 ali1535 i2c driver rmmod oops.
On Wed, Feb 18, 2004 at 03:15:44AM +0000, Dave Jones wrote:
> Erk, whats going on here ?

Hm, I'll try to debug this tomorrow.

Oh nevermind, that's just a dumb driver. It's doing a release_region on
memory it didn't get. Stupid, stupid, stupid...

Dave can you verify that this patch fixes the problem for you?

thanks,

greg k-h


===== i2c-ali1535.c 1.12 vs edited =====
--- 1.12/drivers/i2c/busses/i2c-ali1535.c Tue Jan 20 08:58:03 2004
+++ edited/i2c-ali1535.c Tue Feb 17 20:00:44 2004
@@ -517,6 +517,7 @@
static void __devexit ali1535_remove(struct pci_dev *dev)
{
i2c_del_adapter(&ali1535_adapter);
+ release_region(ali1535_smba, ALI1535_SMB_IOSIZE);
}

static struct pci_driver ali1535_driver = {
@@ -534,7 +535,6 @@
static void __exit i2c_ali1535_exit(void)
{
pci_unregister_driver(&ali1535_driver);
- release_region(ali1535_smba, ALI1535_SMB_IOSIZE);
}

MODULE_AUTHOR("Frodo Looijaard <frodol@dds.nl>, "
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2005-03-22 14:01    [W:0.662 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site