lkml.org 
[lkml]   [2004]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: Linux 2.6.3-rc3
From
Date
Ernst Herzberg <earny@net4u.de> writes:

> Compile warnings with new driver:
>
> [...]
> drivers/video/aty/radeon_base.c: In function `radeon_probe_pll_params':
> drivers/video/aty/radeon_base.c:474: warning: `xtal' might be used uninitialized in this function

This looks like a real bug. I guess the patch below fixes it, but I
can't test it because that code is not executed on my hardware. (And I
doubt it will fix your problem.)

--- linux/drivers/video/aty/radeon_base.c.old 2004-02-15 21:06:02.000000000 +0100
+++ linux/drivers/video/aty/radeon_base.c 2004-02-15 20:57:22.000000000 +0100
@@ -566,8 +566,9 @@
break;
}

- do_div(vclk, 1000);
- xtal = (xtal * denom) / num;
+ vclk *= denom;
+ do_div(vclk, 1000 * num);
+ xtal = vclk;

if ((xtal > 26900) && (xtal < 27100))
xtal = 2700;
> drivers/video/aty/radeon_base.c: In function `radeon_screen_blank':
> drivers/video/aty/radeon_base.c:944: warning: `val2' might be used uninitialized in this function
> drivers/video/aty/radeon_base.c: In function `radeonfb_setcolreg':
> drivers/video/aty/radeon_base.c:1025: warning: `vclk_cntl' might be used uninitialized in this function
> CC net/sunrpc/timer.o
> drivers/video/aty/radeon_base.c: In function `radeon_calc_pll_regs':
> drivers/video/aty/radeon_base.c:1319: warning: `pll_output_freq' might be used uninitialized in this function

I think these warnings are harmless.

--
Peter Osterlund - petero2@telia.com
http://w1.894.telia.com/~u89404340
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:00    [W:0.097 / U:38.152 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site