Messages in this thread | | | Date | Fri, 13 Feb 2004 10:13:07 +0100 (MET) | From | Geert Uytterhoeven <> | Subject | Re: smb_ops_unix warning (was: Re: Linux 2.4.25-rc2) |
| |
On Thu, 12 Feb 2004, Urban Widmark wrote: > On Thu, 12 Feb 2004, Geert Uytterhoeven wrote: > > On Wed, 11 Feb 2004, Marcelo Tosatti wrote: > > > Here goes -rc2, with small number of fixes and corrections. > > > > This patch adds a missing include (fortunately it was included in some other > > include, but its' not clean for files that check CONFIG_* flags) and kills a > > compiler warning (introduced in -rc1, IIRC) if CONFIG_SMB_UNIX is not set. > > Ah, thanks. > > > > Alternatively, perhaps the code can be reshuffled a bit to avoid too many > > ifdefs? > > Code below builds cleanly for me either way, but I have not tested it yet. > Will do that later. > > The config could also be removed, but I like that 2.4 users can keep the > previous 2.4 behaviour if they want to.
I can confirm it has the same result: no more compiler warnings.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |