Messages in this thread | | | Date | Mon, 6 Dec 2004 14:55:39 +0100 | From | Jens Axboe <> | Subject | Re: 2.6: drivers/md/dm-io.c partially copies bio.c |
| |
On Mon, Dec 06 2004, Kevin Corry wrote: > Hi Adrian, > > On Monday 06 December 2004 6:09 am, Adrian Bunk wrote: > > drivers/md/dm-io.c copies functionality from bio.c . > > > > Is there a specific reason why you don't simply use the functionality > > bio.c provides? > > Can you give some specific examples of the functionality you think is > duplicated? Meanwhile, I'll take a look and see if I can explain any code > overlaps.
Ah come on Kevin, a 2 second glance shows lots of uneccesary duplication. Basically only the concept of the bio_set is not duplicated in the first many lines, you even set up matching slabs.
How was that ever accepted for merging?
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |