lkml.org 
[lkml]   [2004]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] isolcpus option broken in 2.6.10-rc2-bk2

* Dimitri Sivanich <sivanich@sgi.com> wrote:

> The isolcpus option is broken in 2.6.10-rc2-bk2. The domains are no longer
> being properly initialized (which results in a panic at bootup).
>
> The following patch fixes this.
>
> Signed-off-by: Dimitri Sivanich <sivanich@sgi.com>

Acked-by: Ingo Molnar <mingo@elte.hu>

only a minor nit:

> + /* Initialize isolated CPU (physical) domains and groups */
> + for_each_cpu_mask(i, cpu_isolated_map) {
> + struct sched_domain *sd = NULL;

there's no need to initialize 'sd' to NULL here.

> + int group;
> +
> + sd = &per_cpu(phys_domains, i);
> + group = cpu_to_phys_group(i);

> + for_each_cpu_mask(i, cpu_isolated_map) {
> + struct sched_domain *sd = NULL;

ditto.

> + int group;
> +
> + sd = &per_cpu(phys_domains, i);
> + group = cpu_to_phys_group(i);
> + *sd = SD_CPU_INIT;

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:08    [from the cache]
©2003-2011 Jasper Spaans