Messages in this thread Patch in this message | | | Date | Sun, 5 Dec 2004 05:15:42 -0500 (EST) | From | Cal Peake <> | Subject | Re: Linux 2.6.10-rc3 oops when 'modprobe -r dvb-bt8xx' |
| |
On Sun, 5 Dec 2004, Eyal Lebedinsky wrote:
> In the spirit of festive testing I would like to say that the oops that I > enjoyed throughout rc2-bk* is still present in -rc3. -mm series does not > have this problem. > > EIP is at bttv_i2c_info+0x36/0x6a [bttv]
Hi Eyal,
From what I can tell the oops comes from the above function calling dvb_bt8xx_i2c_info after the module that holds it (dvb-bt8xx) gets unloaded. The dvb_bt8xx... function has been removed from rc2-mm4 so that's prolly why you don't get the oops in the -mm kernels.
Until the changes propagate from -mm to Linus' tree the below patch should take care of it.
-- Cal
Signed-off-by: Cal Peake <cp@absolutedigital.net>
--- linux-2.6.10-rc3/drivers/media/dvb/bt8xx/dvb-bt8xx.c.orig 2004-12-05 02:19:58.000000000 -0500 +++ linux-2.6.10-rc3/drivers/media/dvb/bt8xx/dvb-bt8xx.c 2004-12-05 05:11:14.000000000 -0500 @@ -331,24 +331,6 @@ return 0; } -static void dvb_bt8xx_i2c_info(struct bttv_sub_device *sub, - struct i2c_client *client, int attach) -{ - struct dvb_bt8xx_card *card = dev_get_drvdata(&sub->dev); - - if (attach) { - printk("xxx attach\n"); - if (client->driver->command) - client->driver->command(client, FE_REGISTER, - card->dvb_adapter); - } else { - printk("xxx detach\n"); - if (client->driver->command) - client->driver->command(client, FE_UNREGISTER, - card->dvb_adapter); - } -} - static struct bttv_sub_driver driver = { .drv = { .name = "dvb-bt8xx", @@ -360,7 +342,6 @@ * .resume = dvb_bt8xx_resume, */ }, - .i2c_info = dvb_bt8xx_i2c_info, }; static int __init dvb_bt8xx_init(void) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |