Messages in this thread | | | Subject | Re: [PATCH] Fix ALSA resume | From | Lee Revell <> | Date | Sat, 04 Dec 2004 16:54:02 -0500 |
| |
Please cc: alsa-devel@lists.sourceforge.net on all ALSA issues.
On Sat, 2004-12-04 at 22:23 +0100, Martin Josefsson wrote: > Some time ago, a patch was merged that removed pci_save_state() and > pci_restore_state() from various ALSA drivers. That patch also added > pci_restore_state() to sound/core/init.c but didn't add pci_save_state() > anywhere. This is needed since the core pci handling doesn't do this for > us anymore. > > My laptop doesn't resume (gets what I assume is an ACPI timeout and > hangs solid) without this small obvious patch. > > Signed-off-by: Martin Josefsson <gandalf@wlug.westbo.se> > Fixed-by: Takashi Iwai <tiwai@suse.de> > > --- linux/sound/core/init.c 8 Nov 2004 11:37:08 -0000 1.48 > +++ linux/sound/core/init.c 12 Nov 2004 13:56:32 -0000 > @@ -782,12 +782,15 @@<br> > int snd_card_pci_suspend(struct pci_dev *dev, u32 state) > { > snd_card_t *card = pci_get_drvdata(dev); > + int err; > if (! card || ! card->pm_suspend) > return 0; > if (card->power_state == SNDRV_CTL_POWER_D3hot) > return 0; > /* FIXME: correct state value? */ > - return card->pm_suspend(card, 0); > + err = card->pm_suspend(card, 0); > + pci_save_state(dev); > + return err; > } > > int snd_card_pci_resume(struct pci_dev *dev) > > -- Lee Revell <rlrevell@joe-job.com>
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |