[lkml]   [2004]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] aic7xxx large integer
    On Sun, 2004-12-05 at 00:16 +0100, Miguel Angel Flores wrote:

    > I post the patch very quickly :(. The original code finally seems OK. My
    > controller is not working with 39 bit addressing, although I can't find
    > why the compiler warns. Maybe the length of dma_addr_t type, in the
    > 2.6.9 the type of the mask_39bit variable is bus_addr_t.

    The compiler warns because you are putting a 64-bit value (an unsigned
    long long) in a 32-bit value (a u32).

    There is definitely a problem on non-highmem compiled kernels, there is
    no doubt of that. The concern was that your suggested fix is not right.

    Assuming that a 39-bit value is really wanted, the type either needs to
    be changed to a dma64_addr_t or the value needs to change at
    compile-time to a suitable 32-bit variant when !CONFIG_HIGHMEM64G.

    Without knowing what the driver is doing, I have no idea.

    Robert Love

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 14:08    [W:0.029 / U:73.912 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site