Messages in this thread | | | Date | Tue, 28 Dec 2004 22:15:26 +0100 | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: PATCH: 2.6.10 - Incorrect return from PCI ide controller |
| |
On Tue, 28 Dec 2004 21:55:53 +0100, Francois Romieu <romieu@fr.zoreil.com> wrote: > Alan Cox <alan@lxorguk.ukuu.org.uk> : > > Several IDE drivers return positive values as errors in the PCI setup > > code. Unfortunately the PCI layer considers positive values as success > > so the driver skips the device but still claims it and things then go > > downhill. > > > > This fixes the IT8172 driver. There are other drivers with this bug (eg > > generic) but the -ac IDE is sufficiently diverged from base that someone > > else needs to generate/test the more divergent cases. > > ide_setup_pci_device{s} will always claim that everything is fine even > though do_ide_setup_pci_device() has some opportunity to fail. > > Should it matter as well ?
Yes. Patches welcomed. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |