lkml.org 
[lkml]   [2004]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: PATCH: 2.6.10 - Incorrect return from PCI ide controller
Alan Cox <alan@lxorguk.ukuu.org.uk> :
> Several IDE drivers return positive values as errors in the PCI setup
> code. Unfortunately the PCI layer considers positive values as success
> so the driver skips the device but still claims it and things then go
> downhill.
>
> This fixes the IT8172 driver. There are other drivers with this bug (eg
> generic) but the -ac IDE is sufficiently diverged from base that someone
> else needs to generate/test the more divergent cases.

ide_setup_pci_device{s} will always claim that everything is fine even
though do_ide_setup_pci_device() has some opportunity to fail.

Should it matter as well ?

--
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:09    [W:0.319 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site