Messages in this thread | | | Subject | Re: [2.6 patch] ieee1394_core.c: remove unneeded EXPORT_SYMBOL's | From | Alan Cox <> | Date | Tue, 21 Dec 2004 00:40:21 +0000 |
| |
On Llu, 2004-12-20 at 23:02, Adrian Bunk wrote: > > What if the driver is under development and doesn't work yet? > > For a driver developer, it shouldn't be a big problem to re-add an > EXPORT_SYMBOL or even to undo an #if 0 of a currently unused function.
Except that the driver author now has to compile entire kernels, can't redistribute it easily to others for testing without them all rebuilding the kernel and has no idea of what things the author intended to be API. In this case it isnt a clean up, but a game plan to reduce the amount and quality of driver submission.
On this one you've clearly gone too far. USB had a pile of API functions before drivers used them, video4linux did the same and that made sense just like this does. Tidy it up in 12-18 months when the drivers exist to know what is worth keeping and what should be removed.
Alan
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |