Messages in this thread | | | Subject | Re: [PATCH] pcxx: replace cli()/sti() with spin_lock_irqsave()/spin_unlock_irqrestore() | From | Alan Cox <> | Date | Mon, 20 Dec 2004 20:23:50 +0000 |
| |
On Llu, 2004-12-20 at 14:59, Alan Cox wrote: > On Gwe, 2004-12-17 at 22:34, James Nelson wrote: > > - save_flags(flags); > > - cli(); > > + spin_lock_irqsave(&pcxx_lock, flags); > > del_timer_sync(&pcxx_timer); > > Not safe if the lock is grabbed by the timer between the lock and the > irqsave as it will spin on another cpu and the timer delete will never > finish.
Error between brain and keyboard
Between the lock and the timer_delete of course - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |