Messages in this thread | | | Date | Thu, 2 Dec 2004 21:56:03 +0100 | From | Guido Guenther <> | Subject | Re: software suspend patch [1/6] |
| |
On Sun, Nov 28, 2004 at 06:11:06PM +0100, Pavel Machek wrote: > Hi! > > > > device-tree.diff > > > base from suspend2 with a little changed. > > > > > > core.diff > > > 1: redefine struct pbe for using _no_ continuous as pagedir. > > > 2: make shrink memory as little as possible. > > > 3: using a bitmap speed up collide check in page relocating. > > > 4: pagecache saving ready. > > > > > > i386.diff > > > ppc.diff > > > i386 and powerpc suspend update. > > > > > > pagecachs_addon.diff > > > if enable page caches saving, must using it, it making saving > > > pagecaches safe. idea from suspend2. > > > > > > ppcfix.diff > > > fix compile error. > > > $ gcc -v > > > .... > > > gcc version 2.95.4 20011002 (Debian prerelease) > > > > > > I'm using 2.6.9-ck3 With above patch, swsusp1 works prefect in my > > > PowerPC and x86 PC with Highmem and prepempt option enabled. > > > > > > I hope the core.diff@1,@2,@3 i386.diff ppc.diff will merge into > > > mainline kernel ASAP, :). from I view point device-tree.diff is > > > very usefuly when using pagecache saving and pagecachs_addon.diff > > > that's really hack for making pagecache saving safe. > > > > > > > --- 2.6.9-lzf/arch/ppc/syslib/open_pic.c 2004-11-26 12:32:58.000000000 +0800 > > +++ 2.6.9/arch/ppc/syslib/open_pic.c 2004-11-28 23:16:58.000000000 +0800 > > @@ -776,7 +776,8 @@ static void openpic_mapirq(u_int irq, cp > > if (ISR[irq] == 0) > > return; > > if (!cpus_empty(keepmask)) { > > - cpumask_t irqdest = { .bits[0] = openpic_read(&ISR[irq]->Destination) }; > > + cpumask_t irqdest; > > + irqdest.bits[0] = openpic_read(&ISR[irq]->Destination); > > cpus_and(irqdest, irqdest, keepmask); > > cpus_or(physmask, physmask, irqdest); > > } Doesn't the former mean initialize irqdest.bits as a whole to zero and .bits[0] to openpic_read(...), while the later only sets iqdest.bits[0] to openpic_read(...)? I think this is wrong. Cheers, -- Guido - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |