Messages in this thread | | | From | Jesse Barnes <> | Subject | Re: [PATCH] add legacy I/O port & memory APIs to /proc/bus/pci | Date | Thu, 16 Dec 2004 09:04:46 -0800 |
| |
On Thursday, December 16, 2004 8:56 am, Christoph Hellwig wrote: > On Thu, Dec 16, 2004 at 08:50:19AM -0800, Jesse Barnes wrote: > > This patch documents the /proc/bus/pci interface and adds some optional > > architecture specific APIs for accessing legacy I/O port and memory > > space. This is necessary on platforms where legacy I/O port space doesn't > > 'soft fail' like it does on PCs, and is useful for systems that can route > > legacy space to different PCI busses. > > Please don't add more interfaces to procfs. And ioctl() on procfs is even > more evil.
Oh come on, there's already an API there, and now it's documented even! The additions are straightforward and there's no where else to put them... /sys doesn't seem like a good place either, would you prefer a device driver?
I really don't see what the problem is though. /proc/bus/pci is a commonly used API and I don't see it going away. These extensions just make it a little more usable on platforms like sn2 and ppc.
Jesse - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |