lkml.org 
[lkml]   [2004]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: VM86 interrupt emulation breakage and FIXes for 2.6.x kernel series
From
Date
On Iau, 2004-12-09 at 13:59, Pavel Pisa wrote:
> if (vm86_irqs[intno].sig)
> send_sig(vm86_irqs[intno].sig, vm86_irqs[intno].tsk, 1);
> /* else user will poll for IRQs */
> + spin_unlock_irqrestore(&irqbits_lock, flags);
> + /* Next line would be required to handle correctly level activated
> interrupts */
> + disable_irq(intno);
> + return IRQ_HANDLED;

You can't disable_irq and return to user space - the IRQ may be shared
by a device needed to make user space progress.

The rest looks like a real bug.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:08    [from the cache]
©2003-2011 Jasper Spaans