lkml.org 
[lkml]   [2004]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.6.10-rc2-mm4
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Chris Wright wrote:
| * Jeffrey Mahoney (jeffm@suse.com) wrote:
|
|>I took some more time to find a more optimal solution. Since ReiserFS is
|>currently the only filesystem that cares about this, it's far easier
to keep
|>the whole mess internal to ReiserFS. The issue isn't about the treating of
|>"private" files in reiserfs, but rather just to avoid the looping of xattr
|>calls that selinux would create.
|
|
| This sounds a bit better. BTW, which is the call chain that locks?
smth like
|
open->permission->selinux_hook_does_getxattr->reiser_getxattr->open->permission?

For the most part yes. The locking stops at reiserfs_getxattr when it
tries to lock the xattr dir.

|>As part of the reiserfs xattr subsystem initialization process, this patch
|>copies the existing inode_operations structs and NULLs out the xattr
|>operations.
|
|
| This seems unecessary, just define the reiserfs_priv_foo structures
| statically, like other inode ops. As it is, looks like it will get
| re-run once for each mounted superblock.

Yes, you're absolutely right. The copies would be better placed in
reiserfs_xattr_register_handlers, which gets run on module load. I'm
ambivalent with respect to copying them at runtime or in the source. The
advantage to copying them is that they automatically inherit any changes
made and don't need to be considered separately.

- -Jeff

- --
Jeff Mahoney
SuSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFBrmusLPWxlyuTD7IRAoPjAJ0d9+QXKmcYg9rM3sCwrgRV2qx8cACeOARi
QkHEpWCCcA7DBjvadyXsD30=
=q/Rh
-----END PGP SIGNATURE-----
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:08    [W:0.304 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site