Messages in this thread | | | Date | Mon, 8 Nov 2004 14:25:04 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: [Linux-fbdev-devel] Re: [PATCH] fbdev: Fix IO access in rivafb |
| |
On Tue, 9 Nov 2004, Antonino A. Daplas wrote: > > In big endian machines, the read*/write* accessors do a byteswap for an > inherently little endian PCI bus. However, rivafb puts the hardwire in big > endian register access, thus the byteswap is not needed. So for 16- and > 32-bit access, instead of read*/write*, use __raw_read*/__raw_write* for all > archs.
Ok, applied with some further simplifications (use "void __iomem *" and suddenly those /2 and /4 just go away - also use __raw_xxxx for the single-byte versions to be consistent).
Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |