lkml.org 
[lkml]   [2004]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] Return EINVAL if read size is not multiple of struct size
The following is a small patch to return EINVAL when the value given
to read() from an event device is not a multiple of
sizeof(struct input_event).

Prior to this patch read() with a size less than sizeof(struct input_event)
would always return 0.
This should probably be marked as an error.

Signed-off by: James Lamanna

--- linux-2.6.9/drivers/input/evdev.c 2004-10-18 14:54:40.000000000 -0700
+++ linux-2.6.9-ev-patch/drivers/input/evdev.c 2004-11-08 12:23:45.495800064 -0800
@@ -183,6 +183,9 @@
if (!list->evdev->exist)
return -ENODEV;

+ if (count % sizeof(struct input_event) != 0)
+ return -EINVAL;
+
while (list->head != list->tail && retval + sizeof(struct input_event) <= count) {
if (copy_to_user(buffer + retval, list->buffer + list->tail,
sizeof(struct input_event))) return -EFAULT;
--
James Lamanna
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2005-03-22 14:07    [W:0.030 / U:31.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site